jemallocator icon indicating copy to clipboard operation
jemallocator copied to clipboard

Published 20 hours ago • verified publisher icon gnzlbg

*: make CI green again

Open BusyJay opened this issue 5 years ago • 5 comments

This PR fixes several compilation warnings and skip function pointer for ctests.

I hope this can be a step to merging #130.

BusyJay avatar Mar 10 '20 16:03 BusyJay

Allocation APIs have been changing rapidly since the end of January. I suggest to merge it first to make it build and test in stable channel and then fix alloc_trait feature when rapid refactor from wg-allocators finish.

BusyJay avatar Mar 10 '20 17:03 BusyJay

@gnzlbg The only one left is the config diff. I don't know what's the purpose of the check and have no clue what's the proper way to fix it. Any suggestions?

BusyJay avatar Mar 23 '20 07:03 BusyJay

It checks that the version of the configure script that autoconf produces matches what's checked in here: https://github.com/gnzlbg/jemallocator/tree/master/jemalloc-sys/configure. You should just need to update that file.

sfackler avatar Mar 23 '20 18:03 sfackler

But the check passes on MacOS but fail on Linux. I'm afraid updating it will just fix one and break the other.

BusyJay avatar Mar 23 '20 19:03 BusyJay

@sfackler I followed your suggestion, and it did break MacOS build. I'm going to disable the check for now.

BusyJay avatar Apr 22 '20 04:04 BusyJay