jemallocator icon indicating copy to clipboard operation
jemallocator copied to clipboard

Published 20 hours ago • verified publisher icon gnzlbg

Upgrade jemalloc to 5.2.1

Open sfackler opened this issue 5 years ago • 8 comments

sfackler avatar Jul 30 '19 22:07 sfackler

@sfackler this LGTM, but CI fails to build everywhere. I don't know if this is due to this PR, or if it also happens on master. How urgent is this for you ?

gnzlbg avatar Jul 31 '19 08:07 gnzlbg

Oh, looks like their makefile changed. I'll look into it.

sfackler avatar Jul 31 '19 14:07 sfackler

It looks like one of the junit tests is failing?

test_prof_log_many_traces:../jemalloc/test/unit/prof_log.c:133: Failed assertion: (jet_prof_log_bt_count()) == (8) --> 10 != 8: Wrong number of backtraces given sample workload
test_prof_log_many_traces (non-reentrant): fail

sfackler avatar Jul 31 '19 16:07 sfackler

Ping - this is now failing for the same reason master is.

sfackler avatar Aug 19 '19 14:08 sfackler

Ping

sfackler avatar Oct 13 '19 01:10 sfackler

Upgrading jemalloc causes so many problems every time that I believe master should be green before performing the upgrade. I don't know when I'll have the time to work on that, but I can mentor anyone who wants to work on it.

gnzlbg avatar Oct 13 '19 07:10 gnzlbg

@gnzlbg @sfackler The problem looks to be in ctest. Do you mind fixing ctest at =0.2.14 (last good version) for the time being?

Recent ctest emits function types where function pointers should be, so the compiler complains.

valtog avatar Oct 30 '19 01:10 valtog

@sfackler I realize that it has been two years, but what is the status of this PR?

Noah-Kennedy avatar Nov 29 '21 19:11 Noah-Kennedy