Dorian Villet

Results 71 comments of Dorian Villet

@BenMorel Have you had a chance to think about this ?

Here's a few examples : ```php interface LocalDateTimeInterval { public static function cast(null|string|self|LocalDate|LocalDateTime|LocalDateInterval|YearWeek|YearMonth|Year $temporal): ?self; public static function containerOf(null|self|LocalDate|LocalDateTime|LocalDateInterval|YearWeek|YearMonth|Year ...$temporals): ?self; public function precedes(self|LocalDate|LocalDateTime|LocalDateInterval|YearWeek|YearMonth|Year $temporal): bool; public function precededBy(self|LocalDate|LocalDateTime|LocalDateInterval|YearWeek|YearMonth|Year $temporal):...

I'm not entirely sure what "adding/subtracting units" means (I've not looked at the Java implementation set, sorry), but I can tell you we already have a "move" method that takes...

I have quite a complex immutable value object representing a time interval (like `2023-09-19T16:43:12/2023-09-19T23:59`). Some of the methods (`isEmpty`, `getInclusiveEnd`, etc) have quite an impact on performances if they are...

Thanks for your answer. I went the `assertObjectEquals` road. I had to write a quite weird implementation of `equals` on another object that uses `LocalDateTimeInterval` internally, but otherwise it went...

I tried adding unit tests in #22, but they do not highlight this issue.. :(

@staabm @TomasVotruba I added the missing unit tests in #20, along with a failing test for `@final`. However, I'm not sure how to implement a fix properly. It would probably...

@jygaulier Should this issue be closed ? (the last comment about `'/^data:` was not implemented AFAIK)