tools-make icon indicating copy to clipboard operation
tools-make copied to clipboard

feat: Support Swift's libBlocksRuntime

Open ngrewe opened this issue 4 months ago • 2 comments

Some time ago, I added support in libobjc2 to using libBlocksRuntime as supplied by Swift's libdispatch instead of the embedded blocks runtime. This was done to alleviate the longstanding issue that both provided the same symbols which made properly packaging libobjc2 in distributions that also package libBlocksRuntime a bit of a hassle.

This PR changes gnustep-make to detect whether it needs to pull in libBlocksRuntime for blocks support. I also extracted the blocks feature checks into a separate m4 file and fixed a small typo in gs_objc_runtime.m4.

ngrewe avatar Sep 02 '25 05:09 ngrewe

Thanks @ngrewe!

@hmelder with this merged can/should we switch to the libdispatch blocks runtime by removing this patch and building libdispatch before libobjc2?

triplef avatar Sep 03 '25 07:09 triplef

I would stick to the libobjc2 runtime and study the implementation in swift first.

hmelder avatar Sep 03 '25 15:09 hmelder

I don't see any problems with this.

rfm avatar Oct 30 '25 09:10 rfm