libs-base Agsdoc html style update

Second PR to work together and comment, @rfm

Aug 22 '24 12:08 rmottola

@rfm I notice some indenting issues. Check generated header or paragraphs.

Here head has too much indentation.

<html lang="en">
    <head>
    <meta charset="utf-8">
    <title>GNUstep Base</title>
    <style type="text/css">
    hr.method-separator { width:25%; margin-left:0; }
    </style>
  </head>

I had a look at - (void) outputNode: (GSXMLNode*)node to: (NSMutableString*)buf whch appears to be the first direct call from outputDocument: L434 and it looks nested fine to me. Do you spot the error?

Here instead P is closed too much, but it may be a different issue, coming from the source comment itself?

    <p>

	The GNUstep Base library is a free software package implementing
        the API of the OpenStep Foundation Kit (tm), including later
	additions.  This documentation package describes the core of the
	Base library, for documentation on additional classes, see the
	BaseAdditions documentation package.
          </p>

Aug 22 '24 12:08 rmottola

Part if the problem is outputting whitespace from around the elements if the gsdic onto the html. I added a fix for the top level elements.

In general the tool doesn't try very hard to indent the html though.

On 22 Aug 2024 at 13:41, Riccardo @.***> wrote:

@rfm I notice some indenting issues. Check generated header or paragraphs.

Here head has too much indentation.
GNUstep Base
I had a look at - (void) outputNode: (GSXMLNode*)node to: (NSMutableString*)buf whch appears to be the first direct call from outputDocument: L434 and it looks nested fine to me. Do you spot the error?

Here instead P is closed too much, but it may be a different issue, coming from the source comment itself?
<p>  The GNUstep Base library is a free software package implementing the API of the OpenStep Foundation Kit (tm), including later additions. This documentation package describes the core of the Base library, for documentation on additional classes, see the BaseAdditions documentation package.  </p>     
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Aug 22 '24 18:08 rfm

AGSHtml.m: In function ‘-[AGSHtml makeLink:ofType:isRef:]’:
AGSHtml.m:307:3: warning: ‘AGSHtml’ may not respond to ‘-makeURL:ofType:isRef:’
   s = [self makeURL: r ofType: t isRef: f];
   ^
AGSHtml.m:307:3: warning: (Messages without a matching method signature
AGSHtml.m:307:3: warning: will be assumed to return ‘id’ and accept
AGSHtml.m:307:3: warning: ‘...’ as arguments.)

Proposed fix: https://github.com/gnustep/libs-base/pull/440/commits/21f2cd0389aad378c52be0afa130ef4dd219f821

@rfm what do you think?

Aug 24 '24 12:08 rmottola