libobjc2 icon indicating copy to clipboard operation
libobjc2 copied to clipboard

Set that same options on the `objc-static` target as the `objc` target

Open madsmtm opened this issue 2 years ago • 3 comments

I still can't get static linking to work, but this makes it slightly better

madsmtm avatar Oct 07 '21 09:10 madsmtm

Thanks. I'd like to get static linking working, but it hasn't been a priority for me (and I'd really like to add static linking to CI tests to make sure it really works).

The CMake is very old (2.x-era stuff) and doesn't look very much like modern CMake. In particular, modern CMake officially supports Objective-C, so we could remove a lot of hacks. I'd be very happy to take patches to clean it up!

The CI failures on Ubuntu look new, can you take a look at them?

davidchisnall avatar Oct 07 '21 10:10 davidchisnall

Can't immediately see why the build failure should be because of this PR.

Anyhow, not very experienced in CMake (primarily Rust background), but I might find the time to tinker with it - no promises though!

madsmtm avatar Oct 07 '21 11:10 madsmtm

From the error, it look as if libunwind is being added on static builds now, but that functionality should come from something with a different name on static builds? Or maybe Ubuntu 18.04's clang just doesn't ship a static libunwind?

davidchisnall avatar Oct 07 '21 12:10 davidchisnall