pybombs icon indicating copy to clipboard operation
pybombs copied to clipboard

add 'builddir' variable, stop abusing 'installdir'

Open ckuethe opened this issue 8 years ago • 4 comments

While fixing https://github.com/gnuradio/gr-etcetera/issues/3 I found that the build dir is set from the 'installdir' variable (https://github.com/gnuradio/pybombs/blob/master/pybombs/packagers/source.py#L212). Kind of confusing. Perhaps there should be a 'builddir' variable containing 'build' unless otherwise overridden.

ckuethe avatar Apr 09 '16 00:04 ckuethe

I agree -- the current behaviour was inherited from PB1. I hate to just break stuff though. Do you have any suggestions that don't break any recipes? Maybe use both?

mbr0wn avatar Apr 12 '16 20:04 mbr0wn

I'll do up a patch to prefer 'builddir' and warn when 'installdir' is used, then we can push that to pip (which will also pick up the updated build-essential change.

Once that's available I'll update the recipes.

ckuethe avatar Apr 12 '16 20:04 ckuethe

Fixed by #299

ckuethe avatar Apr 13 '16 19:04 ckuethe

#299 actually broke a bunch of things, so it was reverted and this bug is thus open again.

mbr0wn avatar May 02 '16 20:05 mbr0wn