gnuradio
gnuradio copied to clipboard
gnuradio
Update qa_zeromq_pushpull.py with IPV6 test loopback
Added test_002 with IPV6 loopback address to fix issue "Can't connect to IPv6 host using ZMQ PULL Source #1866 "
Description
Related Issue
Which blocks/areas does this affect?
Testing Done
Checklist
- [x] I have read the CONTRIBUTING document.
- [x] I have squashed my commits to have one significant change per commit.
- [x] I have signed my commits before making this PR
- [x] My code follows the code style of this project. See GREP1.md.
- [ ] I have updated the documentation where necessary.
- [ ] I have added tests to cover my changes, and all previous tests pass.
Hi! Thanks for tackling this!
Two things: you really have to sign-off your commits, as mentioned :) You can sign-off yours using git commit --amend -s and then git push --force.
However, I think we need to technically adjust things, as well:
@sb424dat thanks for contributing, but we can't take the patch without the signoff. Since this hasn't seen activity for quite a while, I'll close it to keep the PR queue tidy. However, please reopen once you've addressed the comments and DCO signoff.
