booksing icon indicating copy to clipboard operation
booksing copied to clipboard

Images are 404

Open adrianmihalko opened this issue 3 years ago • 7 comments

Hi,

For some reason cover images are not showing:

Screenshot 2021-09-22 at 20 07 58 Screenshot 2021-09-22 at 20 08 08

The files are present in the directory:

Screenshot 2021-09-22 at 20 09 19

adrianmihalko avatar Sep 22 '21 18:09 adrianmihalko

Update: I can't even download books:

WARN[0761] GIN handled request app=booksing clientIP=192.168.1.170 dataLength=19 latency=9 method=GET path=/download referer="http://192.168.1.155:7132/download?hash=benkoarmanyhalojaban" statusCode=404 userAgent="Mozilla/5.0 (X11; U; Linux armv7l like Android; en-us) AppleWebKit/531.2+ (KHTML, like Gecko) Version/5.0 Safari/533.2+ Kindle/3.0+"

WARN[1379] GIN handled request app=booksing clientIP=192.168.1.100 dataLength=19 latency=8 method=GET path=/download referer="http://192.168.1.155:7132/?q=author:L%c3%a1szl%c3%b3%20Benk%c5%91" statusCode=404 userAgent="Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Safari/605.1.15

.epub is missing from the directory, where the images are.

adrianmihalko avatar Sep 22 '21 18:09 adrianmihalko

I don't think I have any books in my collection with so many special characters. Pretty obvious oversight now I think of it, I'm afraid it is related to that. Does this happen with all indexed books or just this one?

I'll do some tests with similarly named files.

gnur avatar Sep 22 '21 18:09 gnur

I was thinking the same, but it doesn't work with english characters either:

"Path": "books/R/J_K_Rowling/J_K_Rowling-Harry_Potter_And_The_Philosoph.epub", "Size": 820064, "HasCover": true, "CoverPath": "books/R/J_K_Rowling/J_K_Rowling-Harry_Potter_And_The_Philosoph.jpg",

.jpg is valid and present in the directory after import, but .epub is missing. For both I get 404.

adrianmihalko avatar Sep 22 '21 18:09 adrianmihalko

That is really weird, do you still happen to have to logs of the indexing? It might have some information.

I really hope it didn't delete the only copies of those books, did they end up in the failed dir maybe?

gnur avatar Sep 22 '21 19:09 gnur

I am one step closer. My import directory is a samba share with read only access. I think Booksing fails when it tries to delete the original file? I did a little test by starting over with a new local import directory and in this case worked, but images are still not working - maybe of the special characters.

It would be great to add an option to not delete files from the original import directory.

adrianmihalko avatar Sep 22 '21 20:09 adrianmihalko

One more question, I installed Calibre. On details page I click on convert to .mobi, the convert is success, but I don't see any option to download .mobi file. It would be nice to show available .epub, .mobi versions on the main page, like this (+ automatic conversion would be even better):

Screenshot 2021-09-22 at 22 54 41

adrianmihalko avatar Sep 22 '21 20:09 adrianmihalko

Ah, I see, I think this is related to #27 It tries to do a rename, which does not work across different file systems.

gnur avatar Oct 01 '21 18:10 gnur