gdl icon indicating copy to clipboard operation
gdl copied to clipboard

remove test_routine_name ?

Open GillesDuvert opened this issue 4 years ago • 5 comments

there is a 'test_routine_nameS' that is used now, apparently for the same purpose.

GillesDuvert avatar Nov 13 '21 10:11 GillesDuvert

So, as of now we have the following files in the testsuite folder:

  • test_routine_dir.pro
  • test_routine_filepath.pro
  • test_routine_name.pro
  • test_routine_names.pro

Only the test_routine_filepath.pro is included in the LIST file, so only this single one is executed during "make test".

test_routine_names.pro fails on CI (and locally as well for me) due to https://github.com/gnudatalanguage/gdl/issues/1188 (which seems to be a regression)

GDL> a='DEADBEEF'XL                                          
% Long integer constant must be less than 2147483648.

slayoo avatar Nov 13 '21 15:11 slayoo

May be someone (me ?) just forgot to add that in LIST ?!

alaingdl avatar Nov 16 '21 14:11 alaingdl

Here's a PR adding test_routine_dir.pro to the list: https://github.com/gnudatalanguage/gdl/pull/1201

slayoo avatar Nov 17 '21 05:11 slayoo

and here one for test_routine_name.pro: https://github.com/gnudatalanguage/gdl/pull/1202

slayoo avatar Nov 17 '21 05:11 slayoo

both passed, so merged (despite this issues's title!)

slayoo avatar Nov 17 '21 15:11 slayoo