gdl icon indicating copy to clipboard operation
gdl copied to clipboard

Keyword parameter <GEO> not allowed in call to: WRITE_TIFF

Open brandy125 opened this issue 4 years ago • 16 comments

Any chance to implement the keyword parameter <GEO> to the write_tiff procedure?

brandy125 avatar Aug 16 '21 15:08 brandy125

@rexso? thanks, Sylwester

slayoo avatar Aug 16 '21 15:08 slayoo

If it is possible implement as well the /float keyword parameter

brandy125 avatar Aug 16 '21 15:08 brandy125

Hi. Sorry for my belated reply.

Due to lack of time, I have not really touched GDL since I changed employer, unfortunately. I would like to contribute when possible, but unfortunately I have no time to look into this the coming week.

Currently WRITE_TIFF is supported through the generic WRITE_IMAGE routine, whereas writing through libtiff would be necessary for geotiff write support. This issue is related to #121 and further mentioned in #288.

Implementing /FLOAT should not be too hard when the fundamentals are in place.

I will see what I can do in September, if the issue is still open then.

rexso avatar Aug 24 '21 16:08 rexso

Hi,

perfect!

Thanks!

On 24. Aug 2021, at 13:03, Remi A. Solås @.***> wrote:

Hi. Sorry for my belated reply.

Due to lack of time, I have not really touched GDL since I changed employer, unfortunately. I would like to contribute when possible, but unfortunately I have no time to look into this the coming week.

Currently WRITE_TIFF is supported through the generic WRITE_IMAGE routine, whereas writing through libtiff would be necessary for geotiff write support. This issue is related to #121 https://github.com/gnudatalanguage/gdl/issues/121 and further mentioned in #288 https://github.com/gnudatalanguage/gdl/pull/288.

Implementing /FLOAT should not be too hard when the fundamentals are in place.

I will see what I can do in September, if the issue is still open then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gnudatalanguage/gdl/issues/1058#issuecomment-904772225, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOC5K6EJSHTAQ45MWUCCM5TT6O7ENANCNFSM5CIAJJ3A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

brandy125 avatar Aug 24 '21 16:08 brandy125

Hi @rexso, hi @slayoo ,

any news on write_tiff with /geotiff and /float support?

working with geotiffs is coming more and more. I think it is very important to have this feature.

brandy125 avatar Apr 03 '22 15:04 brandy125

Just wanted to ask again someone is working on the /geotiff and /float keywords.

brandy125 avatar Apr 14 '22 15:04 brandy125

@brandy125, @rexso had been the only developer working on these features, and we have not heard back from him recently. No news here.

@gnudatalanguage/gdlteam, any volunteers to look at these two missing features? (/geotiff and /float support in write_tiff). Thanks.

slayoo avatar Apr 14 '22 15:04 slayoo

Sorry for my late reply. Unfortunately, due to some long lasting personal problems, I do not have the capacity to work on this implementation right now. I would very much like to do further contributions to the GDL project, but I cannot make any promises at this point. I realise that this is not the answer you were looking for, and i sincerely apologise. I will come back to this tread to let you know when I start working on the implementation. Hopefully I will be able to make myself more useful soon, but for now, this issue is open if someone else want to make an attempt.

Again, I am so sorry for my late reply and for not being able to work on the implementation yet. I appreciate your patience though, and hope for your understanding.

rexso avatar Apr 19 '22 07:04 rexso

@rexso I hope your problems will be solved.

In a project like GDL, it is very classical to give hand-over to others. When a clear interest is express on a given functionality, we can consider to spend some time on it, or to have a student on it. I found it is very valuable for students to spend time to add functionalities in GDL. If you can list the most urgent functionalities & keywords, it is valuable. Examples of snippets are also very useful.

alaingdl avatar Apr 19 '22 08:04 alaingdl

Take care, @rexso, completely no need to apologize!

slayoo avatar Apr 19 '22 13:04 slayoo

@brandy125 It would also be helpful to have a test routine depicting the missing functionality - best a test that works in IDL and fails in GDL as of now.

slayoo avatar Apr 19 '22 13:04 slayoo

@slayoo here is the test routine for checking the keyword /float and geotiff=geotiff:

pro test_write_tiff

        catch, error
        if (error ne 0) then begin
            print, "ERROR: ", error
            print, "Message: ", !ERROR_STATE.MSG
            error=0
            exit,status=1
        endif

        image=dist(10)

        ;test for keyword geotiff
        write_tiff,'image.tif',image,geotiff=geotiff

        ;test for keyword /float
        write_tiff,'image.tif',image,/float

end

Could you please include it to the testsuite folder and add the program in the file LIST?

Output of "make test":

The following tests FAILED: 198 - test_write_tiff.pro (Failed)

Output of log file:

ERROR: -1 Message: WRITE_TIFF: Keyword parameter <GEOTIFF> not allowed in call to: WRITE_TIFF

Test time = 0.11 sec ---------------------------------------------------------- Test Failed. "test_write_tiff.pro" end time: Apr 21 14:27 -03 "test_write_tiff.pro" time elapsed: 00:00:00 ----------------------------------------------------------

In IDL the program runs without error message.

test_write_tiff.pro.zip

brandy125 avatar Apr 21 '22 18:04 brandy125

In the file INSTALL.CMake is written:

$ make -j 3

For other systems, a native project file will be produced.

To launch the tests, run: $ make check

To install, type: $ make install

But it does not find it:

bash$ make check make: *** No rule to make target 'check'. Stop. bash$

Am I doing anything wrong?

On 19. Apr 2022, at 10:56, Sylwester Arabas @.***> wrote:

@brandy125 https://github.com/brandy125 It would also be helpful to have a test routine depicting the missing functionality - best a test that works in IDL and fails in GDL as of now.

— Reply to this email directly, view it on GitHub https://github.com/gnudatalanguage/gdl/issues/1058#issuecomment-1102688708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOC5K6AQ47AWHJJMRE4Y36DVF23RTANCNFSM5CIAJJ3A. You are receiving this because you were mentioned.

brandy125 avatar Apr 21 '22 18:04 brandy125

Fixed: https://github.com/gnudatalanguage/gdl/commit/c13fda894a5375db9bae46998ecc2f4610b633a2 Thank you!

slayoo avatar Apr 21 '22 21:04 slayoo

Hi Guys,

I notice that I’m getting cc’d on a lot of gnudata emails.

I’m not a Developer in your sense of eh word, but just a high level dabbler in IDL/GDL.

Haven’t used C since the VAX was King of the World… 😉

Please feel free to drop my name from the cc list…

Regards,

Andrew

From: Sylwester Arabas @.> Sent: Friday, 22 April 2022 6:36 AM To: gnudatalanguage/gdl @.> Cc: SkippySky @.>; Team mention @.> Subject: Re: [gnudatalanguage/gdl] Keyword parameter <GEO> not allowed in call to: WRITE_TIFF (#1058)

Fixed: https://github.com/gnudatalanguage/gdl/commit/c13fda894a5375db9bae46998ecc2f4610b633a2 c13fda8 Thank you!

— Reply to this email directly, view it on GitHub https://github.com/gnudatalanguage/gdl/issues/1058#issuecomment-1105759273 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AVUZ4PXELDT26Y2DMWRUC4DVGG7MDANCNFSM5CIAJJ3A . You are receiving this because you are on a team that was mentioned. https://github.com/notifications/beacon/AVUZ4PV4T7F7VRWQ4CACNATVGG7MDA5CNFSM5CIAJJ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIHUIYKI.gif Message ID: @.*** @.***> >

-- This email has been checked for viruses by AVG. https://www.avg.com

SkippySky avatar Apr 22 '22 00:04 SkippySky

@SkippySky sorry, my bad. Indeed, the "gdlteam" group is meant for GDL users & super low-volume announcements. I will create a separate "gdldevs" group for such messages. Apologies.

slayoo avatar Apr 22 '22 02:04 slayoo

Goodness – does that mean I’m the only GDL user…. ;-)

A.

From: Sylwester Arabas @.> Sent: Friday, 22 April 2022 12:21 PM To: gnudatalanguage/gdl @.> Cc: SkippySky @.>; Mention @.> Subject: Re: [gnudatalanguage/gdl] Keyword parameter <GEO> not allowed in call to: WRITE_TIFF (#1058)

@SkippySky https://github.com/SkippySky sorry, my bad. Indeed, the "gdlteam" group is meant for GDL users & super low-volume announcements. I will create a separate "gdldevs" group for such messages. Apologies.

— Reply to this email directly, view it on GitHub https://github.com/gnudatalanguage/gdl/issues/1058#issuecomment-1105949721 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AVUZ4PRH3DGIH7QD4IIAKPDVGIHY3ANCNFSM5CIAJJ3A . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AVUZ4PSJ3NXPQVZ6YUSZSNTVGIHY3A5CNFSM5CIAJJ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIHVXIGI.gif Message ID: @.*** @.***> >

SkippySky avatar Oct 11 '22 07:10 SkippySky

Sure, I will work on that!

On 19. Apr 2022, at 10:56, Sylwester Arabas @.***> wrote:

@brandy125 https://github.com/brandy125 It would also be helpful to have a test routine depicting the missing functionality - best a test that works in IDL and fails in GDL as of now.

— Reply to this email directly, view it on GitHub https://github.com/gnudatalanguage/gdl/issues/1058#issuecomment-1102688708, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOC5K6AQ47AWHJJMRE4Y36DVF23RTANCNFSM5CIAJJ3A. You are receiving this because you were mentioned.

brandy125 avatar Oct 11 '22 08:10 brandy125

Any news about missing /geo and /float keywords in write_tiff?

I would really appreciate if someone could work on that.

Thanks!

brandy125 avatar Oct 17 '22 16:10 brandy125

Hi guys, any news here? Someone working on that?

brandy125 avatar Feb 17 '23 15:02 brandy125

@brandy125 look at #1525

GillesDuvert avatar Feb 26 '23 23:02 GillesDuvert