Greg Price

Results 224 comments of Greg Price

It sounds like there are two things going on in this issue: * The blinking cursor is expensive. That's #59327. This is also what the workaround @ben-xx mentions above is...

It sounds like the fix is that Flutter should update the version of `androidx.window` that it pulls in as a dependency, because this issue was fixed there and we just...

> Shouldn't this be closed as it's been merged into flutter? No, there's been no change merged into Flutter to fix this. The `androidx.window` version that Flutter pulls in is...

The maintainer wrote at https://github.com/alwx/react-native-photo-view/issues/98#issuecomment-333112493 : > We currently don't support `resizeMode` on iOS, only `androidScaleType`. The situation may change in the future, but what's important is the fact that...

This works in 1.5.2, and looks like it was fixed in 7731e9d, from #50 (so, probably fixed in 1.3.0 based on timestamps.) So I think it can be closed.

In case the specifics are helpful to anyone else: this was fixed by commit c58fd6b30 from #127 . The fixed version can be pulled in with the following line in...

I think this is not a correct fix -- it risks double-encoding. For example, if `uri` is a properly percent-encoded URL like `https://commons.wikimedia.org/wiki/File:Mezquita_de_Nasirolmolk,_Shiraz,_Ir%C3%A1n,_2016-09-24,_DD_60-62_HDR.jpg`, we would make a request for `https://commons.wikimedia.org/wiki/File:Mezquita_de_Nasirolmolk,_Shiraz,_Ir%25C3%25A1n,_2016-09-24,_DD_60-62_HDR.jpg`,...

I think the route to fixing this issue is probably for us to switch to using a Chrome custom tab for `LaunchMode.inAppWebView` (and therefore by default), instead of a hand-rolled...

@phamquoctrongnta If you're getting an error at build time, then that is a different issue from this one. This error happens at app run time, so after a successful build....

An update: there's an issue for upgrading the version of androidx.window that Flutter pulls in: * #129307 There's active work being done on that upgrade; a couple of previous attempts...