Greg Price

Results 787 comments of Greg Price

Thanks. It looks like you still have a TODO item before this is ready to be reviewed, so marking it as draft for now.

Thanks. Before this can be reviewed, you'll need to revise it to have clear and coherent commits. See the instructions we discussed on a previous PR thread: https://github.com/zulip/zulip-flutter/pull/1830#pullrequestreview-3297396734

Thanks. Some of these commits aren't coherent. For example this commit f314a7444886b3c4ba3f4519ef9968efe3e94eb7: ``` deps: Update pigeon to `26.0.2` from `26.0.1` This commit is the result of the following commands: flutter...

These commits still aren't coherent. As of this commit: e47d7c012 button: Add video chat button in compose box there's a button which doesn't do anything. That would be a buggy,...

> * Is there a need for the Implemented code for the button in compose_box to be split into multiple commits, as i personally feels the code size is moderate...

Chat thread: [#mobile-dev-help > unlike other video icon get filled with color property @ 💬](https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/unlike.20other.20video.20icon.20get.20filled.20with.20color.20property/near/2294564)

When we implement this, it should support links with an anchor at a specific message, and navigate directly to that message, as in #82. This means consuming the /near/ operator...

One particular case where this comes up is where I'm reading conversations in the app, and there's a link to a thread in GitHub (or some other website) and I...

Hmm, interesting. That fix sounds right. I think this points to a different race too, though: you fetch some messages, then they get edited (or reacted to, etc.), then you...

That speedup sounds very interesting! Can you make a version of this that's just the key changes for getting the speedup, without the style changes? (Could be as a separate...