Greg Price

Results 224 comments of Greg Price

> Are these curves specific to flutter apps running on Android? I find that the scrolling curve on Linux also jumps a little towards the end. This scroll physics is...

Great! Thanks for all the testing. Hoping those internal tests all come back green.

Following up on the above: it looks like @BuzzBumbleBee began a design doc for this feature: https://docs.google.com/document/d/1ebFrip3jv9xMAL8VdhIS_88wiI13XeH4QajOBBIeaQM/edit As I read the discussion there, the main open question is what the...

Thanks! Everything looks great as far as I'm concerned, except for one nit I mentioned above which seems still open: https://github.com/flutter/flutter/pull/118610#discussion_r1112513249 You'll still need reviews from two Flutter contributors. Hopefully...

If you take a look at the diff in the "Files" tab here on GitHub, you'll see that there are now a lot of changes happening that are to the...

Cool. Everything in the PR now looks great as far as I'm concerned.

Ah, excellent point. > I think the best api is to have a `Widget Function(String) errorBuilder` property on `InputDecoration`. This callback allows to convert any `InputDecoration.errorText` to a widget. I...

> Thank you, guys, for your help and support. > If all is good then what's the next step as this is my first PR I don't know. In general...

Thanks for the review! Yes indeed, I plan to follow up soon. Sorry for the delay — was on vacation when the review arrived, and just getting back to things...