Greg Price

See also #3829, #3731, #3584, #2374. And #3247 is an issue with a similar nature on a different codepath: double-sends of posting an emoji reaction to a message.

OK, and in particular: > > * Outbox messages may be _successfully_ sent multiple times. > > Definitely possible in principle: I think the scenario would be that a send...

> `outboxSending` is stored in Redux. If the app is dehydrated with that set to `true`, then killed, there is no mechanism that will clear it. Aha. There's actually a...

> The message-sending tasks are completely loose – their conclusion is unordered with the rest of the program, so there's no sequencing between them and `outboxSending` being unset. In particular,...

Looking again at this code, I think the basic problem is that that `outboxToSend.forEach` loop is a `forEach` loop, and the code (as quoted in my previous comment) was clearly...

> Aha. There's actually a good reason this can't happen. [...] `state.session` is among the parts of our Redux state we specifically don't have `redux-persist` put into persistent storage. This...

> the presence of an unsendable message in the Outbox will prevent any other messages from being sent for a week Yeah, we should behave differently on * a 4xx...

> Marking as blocked by #4193, then That PR was merged (after being split in two: #4753, #4754), so unblocking.

I think the next step, when we pick this thread of work up again, will be to take [that chat thread](https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.23M3881.20Sending.20outbox.20messages.20is.20fraught.20with.20issues/near/1076857) from 2020-12 and make a fresh draft of the...

Thanks for that recording — that's very helpful. What I see is: * You try to use the system's sharing feature to share to Zulip. * It reaches the Zulip...