ethcontract-rs icon indicating copy to clipboard operation
ethcontract-rs copied to clipboard

Hardhat support probably shouldn't depend on hardhat-deploy

Open banshee opened this issue 2 years ago • 1 comments

Looking at the hardhat config in examples/hardhat/hardhat.config.js, you start with:

require("hardhat-deploy");

That seems a bit unusual; we certainly use hardhat, but we took a quick look at hardhat-deploy and decided it wasn't necessary. I guess it makes sense to support hardhat-deploy in addition to the mainstream, but it shouldn't be a requirement.

banshee avatar Mar 04 '22 19:03 banshee

Looking deeper at the code, I think the hardhat support is just misnamed; it's really support for hardhat-deploy and not for hardhat at all. Things like fn _load_from_directory talk about directory structures that are completely different from normal hardhat.

banshee avatar Mar 04 '22 20:03 banshee