From batch id in of the order is incorrect

[anxolin]

I understand the batch id here should start at 19:10, not at 19:05 ☝️

[alfetopito]

What exactly is wrong here?

To try to reproduce the issue, I placed one order valid for exactly 1 batch. Since the validuntil/validfrom are inclusive, that means both values are the same:

https://rinkeby.etherscan.io/tx/0x8ea796f882d6d2b73f5b2a88232cbe4c9c038cf4204fc96cae19e91e2538789b#eventlog

validFrom :5316143
validUntil :5316143

I pointed my dex-cli to rinkeby querying that order, and this is the result:

Note at the bottom that I also check what is the date from the given batchId 5316143.

It gives the same result.

---

I understand the batch id here should start at 19:10, not at 19:05 point_up

I don't see what's wrong here. Why should the batch id start from 19:10 in the example?

[nlordell]

This also seems correct to me. The order is valid in batch 5301445 which starts at 19:05 and ends at 19:10 (which would make sense if an order was placed to be valid immediately at 19:07). The solver will only be able to submit a solution in the following batch so, between 19:10 and 19:14.

In the JS console:

new Date(5301445 * 300 * 1000) // == Mon May 25 2020 21:05:00 GMT+0200 (Central European Summer Time)