dex-services
dex-services copied to clipboard
gnosis
Off-chain services for the Gnosis Protocol v1.
Not sure if or how we fix this but wanted to document the problem. I have multiple PRs that are supposed to be merged in a row and depend on...
It looks like we aren't exercising the price estimation or economic viability code on CI because we are failing to retrieve ERC20 token info: https://travis-ci.com/github/gnosis/dex-services/jobs/371687105#L2581
See discussion https://github.com/gnosis/dex-services/pull/1293#discussion_r469008404
https://github.com/gnosis/dex-services/pull/1295 discovered that an almost zero price will change to infinite when inversed which fails the debug assertion in LimitPrice. When this is fixed we can merge the PR.
This will allow us to separate verified solutions from attempted (satisfying economic viability) and measure how long it takes us from attempting to submit a solution to actually submitting it.
It appears that retrieving certain price estimates is failing for Dex.ag. For example retrieving a price for DAI to aLINK fails. This appears to be an issue even when using...
Maybe this is interesting. I don't know. If it is not, then please just close the ticket: I was looking into the following [instance](https://gnosis-dev-dfusion.s3.amazonaws.com/data/mainnet_dev/best-ring-solver/instances/2020-07-28/instance_5319696_2020-07-28T04%3A05%3A31.300913921%2B00%3A00.json) and found that the WETH price...
This would have caught https://github.com/gnosis/dex-services/pull/975 . > Maybe we should add notifications in our coverage decreases significantly on a single PR: https://docs.coveralls.io/coveralls-notifications to be notified of issues in the future?
Remove these lines once we upgrade `ethcontract`: https://github.com/gnosis/dex-services/blob/36664ed4b0bc9ae585af16ab590a1e54e4e57a20/core/src/contracts/stablex_contract.rs#L1-L3
We currently use OWL buy orders for estimating token prices, but these estimates tend to be quite far from the final OWL prices for tokens found by the solvers. The...