Remove the naive solver?

[e00E]

https://github.com/gnosis/dex-services/pull/864 changes ci to use the standard solver instead of the naive solver. Should we remove the naive solver from the code base?

https://github.com/gnosis/dex-services/pull/864#pullrequestreview-410906827

When I incorporated the open solver, we said that either we should continue testing the naive solver or completely remove it from the codebase.

Since the open-solver is more and more mature, now my vote would be to remove the naive solver.

https://github.com/gnosis/dex-services/pull/864#issuecomment-627977804

My argument against removing the naive solver or even running our CI with this open solver instead is that we wanted something quick that would give us a valid end to end test that does not take too long to run.

I am not strongly opposed to this, but just want to point out this fact that the naive solver is still the fastest solver we have.

[josojo]

My argument against removing the naive solver or even running our CI with this open solver instead is that we wanted something quick that would give us a valid end to end test that does not take too long to run.

The run-time of the open-solver for the e2e test is also instant, so I don't think that this should be a bigger blocker for using the open-solver

[nlordell]

My only issue with the open solver is the setup. I think if we remove the naive solver we should definitely have the open-solver setup well documented somewhere in the README and make it so it doesn't have to install to /app.

[fleupold]

For local testing of unrelated features it is nice to not require a solver setup. But maybe this can be accomplished by a mocked solver that always returns the trivial solution regardless of the input.