dex-contracts icon indicating copy to clipboard operation
dex-contracts copied to clipboard

[Sharing is Caring] Move `truffle-assertions` typings upstream.

Open nlordell opened this issue 5 years ago • 2 comments

They can either be moved to be part of the truffle-assertions project directly or part of the @types organization.

They are relatively simple typings here: https://github.com/gnosis/dex-contracts/blob/master/types/truffle-assertions/index.d.ts

nlordell avatar May 07 '20 07:05 nlordell

I'm not sure I understand the goal here. Are we to move the content of the file linked in the description to a different repo? Like truffle-assertions?

bh2smith avatar May 22 '20 13:05 bh2smith

Turns out its a little more complicated - there are some type dependencies that need to be setup correctly.

nlordell avatar May 22 '20 13:05 nlordell