Bad View Function Name

Open fleupold opened this issue 5 years ago • 1 comments

This method should be called getEncodedOrdersPaginated

https://github.com/gnosis/dex-contracts/blob/cc4c230d113334189aa0ed8d45869cb9bbba3faa/contracts/BatchExchange.sol#L479

It's not worth renaming and redeploying for that matter (renaming without redeploying might cause incompatibilities with dependent infrastructure pieces). However, it should be fixed in case we need to redeploy again.

Feb 03 '20 10:02 fleupold

What about creating a git tag for accumulating ideas to evaluate in case of a redeployment?

Apr 07 '20 13:04 anxolin