Custom slippage around 5% reverts for some values to a lower value

[MareenG]

Describe the bug When setting a custom slippage around 5% a wrong notification is shown for some values

How to Reproduce Steps to reproduce the behavior:

1. Go to settings
2. Set custom value between 5.00 - 5.1% in 0.01% steps
3. See error for 5.02% and 5.06% - Enter a valid slippage percentage

Expected behavior Your transaction may be frontrun should be shown

Screenshots ...

[annamsgeorge]

I see a different issue here: We shoudln't display the text "your order might be front run". This can't happen in GP, I guess we copied this from Uniswap but it doesn't apply in GP. I will create a new ticket for this.

[annamsgeorge]

--> opened new issue for my point, suggesting to remove the error message: Wrong message about slippage and being front run #675

[elena-zh]

The issue with 5.02 and 5.06 slippage percentages is still reproducible in v.0.17: slippage value is reverted to a previous one when enter these amounts.

[MareenG]

Not reproducible in v1.0.0 closing it

[elena-zh]

I'm able to reproduce the issue in v.1.0.0 https://drive.google.com/file/d/1wrbyzc-cUpiDBNya0so3wJEDGejXFfYc/view

[MareenG]

True, it still reverts but doesn't show enter a valid slippage percentage anymore

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.