Improve presentation of error messages

[MareenG]

Might be cool to add some cow theme to the error messages (e.g. sad cow or cow tipping image, spilled milk...)

[anxolin]

Good catch. I agree with the suggestion, also we should handle this error better and display also a nicer message. I'll move this to our backlog and rename this issue so it's more broad (Better and nicer error handling) @michelbio is working in finding some nice illustrations for the website exactly for these situations.

Tasks

• [ ] Improve message for error posting orders. We need to identify the types of errors, and display comprehensive messages for all of them.
• [ ] Use a image/images for the error messages. One funny and easy way is to do a tipped cow saying something: https://en.wikipedia.org/wiki/Cowsay#:~:text=cowsay%20is%20a%20program%20that,bubbles%20rather%20than%20speech%20bubbles.%20.
• [x] Style the 404 page and cow it up
• [ ] Review other errors in the app, like error with normal transactions
• [x] https://github.com/gnosis/gp-ui/issues/347
• [ ] BONUS: We probably want to move to a separate issue. If there's a run-time unhandled error we show a white page. This is the same behaviour as uniswap, and although it should never happen, it did in the past (if you enter negative slippage, and in some other situations). The task would be to have a last resource error handling, that shows a cow saying that there was an internal error (instead of internal error, she should say something more funny though :P )
• [x] Related to https://github.com/gnosis/gp-ui/issues/285

Notes for implementation

The API already provide a type field that shows the kind of error. So we can use this to handle these situations.

• MissingOrderData,
• InvalidSignature,
• DuplicateOrder,
• InsufficientFunds

EDIT: Adding some extra types after syncing the types:

• PastValidTo,
• InsufficientFee,

However, I didn't see one for the error of the date being in the past. @fleupold Is it possible that the swagger docs is not in sync with the types?

[fleupold]

Yes, good catch. It's not synced (https://github.com/gnosis/gp-v2-services/pull/417 updates it)

[MareenG]

I got several failed to fetch error messages today and and the error message displayed in #357. As a user it is hard to understand what is going on.

[MareenG]

I started a list to collect the error messages. Here we can add info on what caused the error and if it needs rewording and/or improved presentation

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.