cowswap icon indicating copy to clipboard operation
cowswap copied to clipboard

The app broke when type anything instead of # in the URL

Open elena-zh opened this issue 3 years ago • 6 comments

A real edge-case: the app broke when type anything instead of # in the URL

image.png

Expected: show 404 error page?

elena-zh avatar Oct 20 '21 15:10 elena-zh

Hmmm, was it like that before? I'm not sure.

My assumption (without looking at the code) is that this happens because the app router is not reached without #

Indeed we could show a 404. Or also redirect to #swap

alfetopito avatar Oct 20 '21 17:10 alfetopito

Weirdly enough, though, it works for me: screenshot_2021-10-20_10-25-01

I mean, not exactly like your case. What I did was: type cowswap.exchange/kdhasjda It loads the app with garbage before #swap

alfetopito avatar Oct 20 '21 17:10 alfetopito

@alfetopito , yes, the root course of the issue is missing # in the URL https://watch.screencastify.com/v/UUeyz2BMtV1s3ieEZMGH

elena-zh avatar Oct 21 '21 09:10 elena-zh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.

stale[bot] avatar Jan 03 '22 19:01 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.

stale[bot] avatar Mar 30 '22 10:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.

stale[bot] avatar Jun 23 '22 04:06 stale[bot]