cowswap icon indicating copy to clipboard operation
cowswap copied to clipboard

Notification pop-ups are still displayed when change networks/disconnect a wallet

Open elena-zh opened this issue 3 years ago • 5 comments

  1. Run a transaction
  2. Right after transaction end, disconnect a wallet OR change a network

AR: Notification pop-ups are still displayed Notifications even may appear when disconnect a wallet while transaction is in 'pending' state. Then, notification will be shown on the transaction end. notifications.jpg

ER: Notifications are closed when disconnect a wallet/change an account

elena-zh avatar Aug 03 '21 12:08 elena-zh

Hmm, I think this is the expected behaviour, as the actions are bound to the interface, not necessarily to an address.

@anxolin @michelbio @W3stside what do you think?

alfetopito avatar Aug 03 '21 18:08 alfetopito

One of cases is that I see 'View on Etherscan' link to a transaction when it is minted in xDAI. So, I approve token in xDAI, then switch to the Mainnet/Rinkeby when notification is displayed.. And see 'View on Etherscan' link there (I have approved WETH in xDAI on the screenshot). blockscount

When I press on the link, it navigates me to the etherscan, however, should navigate to the blockscount https://rinkeby.etherscan.io/tx/0xbfb60f21bc73ddfda259be23e7337c688e76e7025efd9e99c5a8f35f4a14bec3

elena-zh avatar Aug 04 '21 09:08 elena-zh

Hmmm good point

alfetopito avatar Aug 04 '21 18:08 alfetopito

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.

stale[bot] avatar Mar 30 '22 13:03 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you think it shouldn't be closed, speak now or forever hold your peace.

stale[bot] avatar Jun 20 '22 04:06 stale[bot]