cow-dex-solver

cow-dex-solver copied to clipboard

Explicitly mention that version is untracked in Cargo.toml

1

The version number was lagging behind and no one depends on this version number. This change makes this fact explicit. Thanks Martin for the suggestion.

fedgiac

Runtime Panic in Slippage Computation

1

There appears to be a runtime panic introduced in the slippage computation: ``` 2022-11-04T12:38:43.557Z ERROR cowdexsolver::tracing_helper: thread 'tokio-runtime-worker' panicked at 'denominator == 0', /root/.cargo/registry/src/github.com-1ecc6299db9ec823/num-rational-0.4.0/src/lib.rs:132:13: thread 'tokio-runtime-worker' panicked at 'denominator ==...

nlordell

Hashmap makes no guarantees about order which includes not guaranteeing true randomness which means we could loop forever. I'm wondering if you could refactor the input to that function in...

nlordell