terminator icon indicating copy to clipboard operation
terminator copied to clipboard

Terminator can't start launcher properly

Open arne-fuchs opened this issue 3 years ago • 4 comments

Describe the bug I want to start Elite Dangerous with the MinEdLauncher through steam. Before terminator I started it with gnome-terminal: MANGOHUD=1 gnome-terminal -- ./MinEdLauncher %command% /autoquit Everything works fine. I've tried to open it with terminator with the following command: MANGOHUD=1 terminator -x ./MinEdLauncher %command% /autoquit and had following problems:

  1. In the %command% part is a path leading to the elite dangerous. In this path there is a space between Elite and Dangerous. Suddenly the MinEdLauncher thought it would be two arguments instead of one. I could fix that in the program but it didn't happened in gnome-terminal.
  2. Steam provides the wineprefix through a environmental variable called STEAM_COMPAT_DATA_PATH. Somehow this variable gets lost in terminator. Defining it in the launch options didn't helped.

To Reproduce Steps to reproduce the behavior:

  1. Install Elite Dangerous through steam
  2. Install MinEdLauncher
  3. Change the launch options to open the MinEdLauncher
  4. Start game through
  5. If it failes, read logs at ~/.local/state/min-ed-launcher

Expected behavior parsing the arguments through without messing it up and providing environmental variables.

Desktop (please complete the following information):

  • Ubuntu
  • 22.04
  • X11

Config [global_config] title_hide_sizetext = True title_transmit_fg_color = "#000000" title_transmit_bg_color = "#992500" title_receive_fg_color = "#ff7800" title_receive_bg_color = "#c64600" title_inactive_fg_color = "#c64600" title_inactive_bg_color = "#000000" title_use_system_font = False title_font = Tlwg Mono Bold 13 [keybindings] [profiles] [[default]] background_darkness = 1.0 cursor_shape = ibeam cursor_color = "#c64600" cursor_color_fg = False foreground_color = "#e66100" scrollback_lines = 1000 palette = "#000000:#cc0000:#4e9a06:#c4a000:#3465a4:#75507b:#06989a:#d3d7cf:#555753:#ef2929:#8ae234:#fce94f:#729fcf:#ad7fa8:#34e2e2:#eeeeec" split_to_group = True background_image = /home/arne/Pictures/Screenshots/Screenshot from 2022-08-13 03-05-41.png [layouts] [[default]] [[[window0]]] type = Window parent = "" [[[child1]]] type = Terminal parent = window0 [plugins]

arne-fuchs avatar Aug 19 '22 11:08 arne-fuchs

you could try MANGOHUD=1 terminator -x 'STEAM_COMPAT_DATA_PATH=foo ./MinEdLauncher %command% /autoquit'

mattrose avatar Aug 20 '22 20:08 mattrose

I am in vacation now. Will test it next week

arne-fuchs avatar Aug 21 '22 04:08 arne-fuchs

It worked. But it failed to start steam now for unknown reason. I'll leave the issue open. It seems to mess things really up if you start it through steam.

arne-fuchs avatar Aug 26 '22 21:08 arne-fuchs

Tried it in urxvt terminal. No problems.

arne-fuchs avatar Sep 05 '22 09:09 arne-fuchs

There's been some fixing of how we handle command line arguments. Can you check master to see if it's fixed?

mattrose avatar Jan 16 '23 23:01 mattrose

Cloned the repo from master and did a setup build and install. I pasted the arguments mentioned in the issue above but resulted in instant crashing from the launcher. Launcher was not able to write any logs

arne-fuchs avatar Jan 17 '23 00:01 arne-fuchs

I noticed by the way, that the setup.py is only to able to install the program, but not removing it, which is missing.

arne-fuchs avatar Jan 17 '23 00:01 arne-fuchs

Is there any errors from terminator? Possibly terminator is still doing something weird.

mattrose avatar Jan 18 '23 16:01 mattrose

I noticed by the way, that the setup.py is only to able to install the program, but not removing it, which is missing.

It does if you follow the Installation Instructions

mattrose avatar Jan 18 '23 16:01 mattrose

I'm not sure what more I can do to help you in this case.

mattrose avatar Jan 22 '23 01:01 mattrose

For now I am using Rxvt so I am closing the issue. Thanks for helping though!

arne-fuchs avatar Jan 22 '23 10:01 arne-fuchs