feat(gnokey): -broadcast=true by default
This PR replaces https://github.com/gnolang/gno/pull/3725 after discussion.
- In the gnokey
maketx.go, change the-broadcastflag to default true - In gnoweb, update
command.htmlso that the help page gnokey commands are correct - Update examples in the markdown files
- Update txtar files to remove
-broadcastor add-broadcast=falsewhere needed. (This is most of the changed files.) - I didn't remove the
-broadcastflag from this script because I'm not sure that it will run on a machine with the updatedgnokey. (It doesn't hurt to leave the flag.) - I didn't change the folders
gno.land/genesisormisc/deployments
🛠 PR Checks Summary
🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff 🔴 Changes related to gnoweb must be reviewed by its codeowners
Manual Checks (for Reviewers):
- [ ] IGNORE the bot requirements for this PR (force green CI check)
Read More
🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.
✅ Automated Checks (for Contributors):
🟢 Maintainers must be able to edit this pull request (more info) 🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff 🔴 Changes related to gnoweb must be reviewed by its codeowners 🟢 Pending initial approval by a review team member, or review from tech-staff
☑️ Contributor Actions:
- Fix any issues flagged by automated checks.
- Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include
BREAKING CHANGEnotes. - Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
- Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met └── 🟢 And ├── 🟢 The base branch matches this pattern: ^master$ └── 🟢 The pull request was created from a fork (head branch repo: jefft0/gno)Then
🟢 Requirement satisfied └── 🟢 Maintainer can modify this pull requestChanges to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff
If
🟢 Condition met └── 🟢 And ├── 🟢 The base branch matches this pattern: ^master$ └── 🟢 A changed file matches this pattern: ^docs/ (filename: docs/builders/deploy-packages.md)Then
🔴 Requirement not satisfied └── 🔴 And ├── 🔴 Or │ ├── 🔴 Pull request author is a member of the team: tech-staff │ └── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request(with state "APPROVED") └── 🔴 Or ├── 🔴 Pull request author is a member of the team: devrels └── 🔴 At least 1 user(s) of the team devrels reviewed pull request(with state "APPROVED")Changes related to gnoweb must be reviewed by its codeowners
If
🟢 Condition met └── 🟢 And ├── 🟢 The base branch matches this pattern: ^master$ └── 🟢 A changed file matches this pattern: ^gno.land/pkg/gnoweb/ (filename: gno.land/pkg/gnoweb/components/ui/command.html)Then
🔴 Requirement not satisfied └── 🔴 Or ├── 🔴 Or │ ├── 🔴 And │ │ ├── 🔴 Pull request author is user: alexiscolin │ │ └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED") │ └── 🔴 And │ ├── 🔴 Pull request author is user: gfanton │ └── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED") └── 🔴 And ├── 🟢 Not (🔴 Pull request author is user: alexiscolin) ├── 🟢 Not (🔴 Pull request author is user: gfanton) └── 🔴 Or ├── 🔴 This user reviewed pull request: alexiscolin (with state "APPROVED") └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")Pending initial approval by a review team member, or review from tech-staff
If
🟢 Condition met └── 🟢 And ├── 🟢 The base branch matches this pattern: ^master$ └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)Then
🟢 Requirement satisfied └── 🟢 If ├── 🟢 Condition │ └── 🟢 Or │ ├── 🟢 User notJoon already reviewed PR 4965 with state APPROVED │ ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request │ └── 🔴 This pull request is a draft └── 🟢 Then └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met └── 🟢 On every pull requestCan be checked by
- Any user with comment edit permission
Codecov Report
:x: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| gno.land/pkg/keyscli/maketx.go | 0.00% | 1 Missing :warning: |
:loudspeaker: Thoughts on this report? Let us know!