gno icon indicating copy to clipboard operation
gno copied to clipboard

feat: OTEL traces integration

Open Villaquiranm opened this issue 2 months ago โ€ข 3 comments

alternative to #2434

Taking into account some of the reviews on #2434

I tried to integrate traces first on gRPC server. This already works on a basic form but we still need to identify important places were to put the traces image

Added more traces direclty on rpc handlers image image

Villaquiranm avatar Oct 20 '25 12:10 Villaquiranm

๐Ÿ›  PR Checks Summary

All Automated Checks passed. โœ…

Manual Checks (for Reviewers):
  • [ ] IGNORE the bot requirements for this PR (force green CI check)
Read More

๐Ÿค– This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

โœ… Automated Checks (for Contributors):

๐ŸŸข Maintainers must be able to edit this pull request (more info) ๐ŸŸข Pending initial approval by a review team member, or review from tech-staff

โ˜‘๏ธ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
โ˜‘๏ธ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
๐Ÿ“š Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

๐ŸŸข Condition met
โ””โ”€โ”€ ๐ŸŸข And
    โ”œโ”€โ”€ ๐ŸŸข The base branch matches this pattern: ^master$
    โ””โ”€โ”€ ๐ŸŸข The pull request was created from a fork (head branch repo: Villaquiranm/gno)

Then

๐ŸŸข Requirement satisfied
โ””โ”€โ”€ ๐ŸŸข Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

๐ŸŸข Condition met
โ””โ”€โ”€ ๐ŸŸข And
    โ”œโ”€โ”€ ๐ŸŸข The base branch matches this pattern: ^master$
    โ””โ”€โ”€ ๐ŸŸข Not (๐Ÿ”ด Pull request author is a member of the team: tech-staff)

Then

๐ŸŸข Requirement satisfied
โ””โ”€โ”€ ๐ŸŸข If
    โ”œโ”€โ”€ ๐ŸŸข Condition
    โ”‚   โ””โ”€โ”€ ๐ŸŸข Or
    โ”‚       โ”œโ”€โ”€ ๐Ÿ”ด At least one of these user(s) reviewed the pull request: [jefft0 leohhhn n0izn0iz notJoon omarsy x1unix] (with state "APPROVED")
    โ”‚       โ”œโ”€โ”€ ๐ŸŸข At least 1 user(s) of the team tech-staff reviewed pull request
    โ”‚       โ””โ”€โ”€ ๐Ÿ”ด This pull request is a draft
    โ””โ”€โ”€ ๐ŸŸข Then
        โ””โ”€โ”€ ๐ŸŸข Not (๐Ÿ”ด This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

๐ŸŸข Condition met
โ””โ”€โ”€ ๐ŸŸข On every pull request

Can be checked by

  • Any user with comment edit permission

Gno2D2 avatar Oct 20 '25 12:10 Gno2D2

Looks good ๐Ÿ’ฏ

Please drop the gRPC mode for the telemetry entirely ๐Ÿ™

Thanks for the review Miloลก, I think I have answered all your comments

Villaquiranm avatar Dec 03 '25 20:12 Villaquiranm

LGTM

Dysta avatar Dec 16 '25 08:12 Dysta