gno
gno copied to clipboard
chore: gnoweb rework & QoL
This PR slightly reorganizes gnoweb to maintain cleanliness due to cumulative changes in the package:
- Use package.json for versioning and keep it in the tools folder.
- Separate the RPC client from rendering, as the client was responsible for rendering as well, which made manipulation at the handler level difficult.
- Update and fix comments and messages.
- Fix development dependencies in the makefile.
- Add basic caching for assets
🛠 PR Checks Summary
All Automated Checks passed. ✅
Manual Checks (for Reviewers):
- [ ] IGNORE the bot requirements for this PR (force green CI check)
Read More
🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.
✅ Automated Checks (for Contributors):
🟢 Maintainers must be able to edit this pull request (more info) 🟢 Changes related to gnoweb must be reviewed by its codeowners
☑️ Contributor Actions:
- Fix any issues flagged by automated checks.
- Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include
BREAKING CHANGEnotes. - Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
- Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met └── 🟢 And ├── 🟢 The base branch matches this pattern: ^master$ └── 🟢 The pull request was created from a fork (head branch repo: gfanton/gno)Then
🟢 Requirement satisfied └── 🟢 Maintainer can modify this pull requestChanges related to gnoweb must be reviewed by its codeowners
If
🟢 Condition met └── 🟢 And ├── 🟢 The base branch matches this pattern: ^master$ └── 🟢 A changed file matches this pattern: ^gno.land/pkg/gnoweb/ (filename: gno.land/pkg/gnoweb/.gitattributes)Then
🟢 Requirement satisfied └── 🟢 Or ├── 🟢 Or │ ├── 🔴 And │ │ ├── 🔴 Pull request author is user: alexiscolin │ │ └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED") │ └── 🟢 And │ ├── 🟢 Pull request author is user: gfanton │ └── 🟢 This user reviewed pull request: alexiscolin (with state "APPROVED") └── 🔴 And ├── 🟢 Not (🔴 Pull request author is user: alexiscolin) ├── 🔴 Not (🟢 Pull request author is user: gfanton) └── 🟢 Or ├── 🟢 This user reviewed pull request: alexiscolin (with state "APPROVED") └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met └── 🟢 On every pull requestCan be checked by
- Any user with comment edit permission
Codecov Report
Attention: Patch coverage is 77.90698% with 114 lines in your changes missing coverage. Please review.
:loudspeaker: Thoughts on this report? Let us know!