refactor: move no_cycles_test.go to gno.land/pkg/gnoland
examples/no_cycles_test.go was introduced in https://github.com/gnolang/gno/pull/3304, and we still want to keep it.
However, it creates an issue because the examples folder contains code that is not an example, which is not user-friendly.
Additionally, I believe it is currently not tested by the CI.
I suggest moving it to gno.land/pkg/gnoland, as I think that would be a suitable location, but I am open to other suggestions.
Depending on https://github.com/gnolang/gno/pull/4351, we may need to patch this test file to ignore stdlib.
cc @n0izn0iz @thehowl
🛠 PR Checks Summary
All Automated Checks passed. ✅
Manual Checks (for Reviewers):
- [ ] IGNORE the bot requirements for this PR (force green CI check)
Read More
🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.
✅ Automated Checks (for Contributors):
🟢 Maintainers must be able to edit this pull request (more info)
☑️ Contributor Actions:
- Fix any issues flagged by automated checks.
- Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include
BREAKING CHANGEnotes. - Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
- Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met └── 🟢 And ├── 🟢 The base branch matches this pattern: ^master$ └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)Then
🟢 Requirement satisfied └── 🟢 Maintainer can modify this pull requestManual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met └── 🟢 On every pull requestCan be checked by
- Any user with comment edit permission
The move looks good, but the test doesn't work. Maybe @n0izn0iz could make a PR fixing it up as well?
@thehowl @moul I updated the test in this branch https://github.com/gnolang/gno/pull/4439 Couldn't open a PR against moul's fork so had to open it against gnolang's
merged #4439 instead