gno icon indicating copy to clipboard operation
gno copied to clipboard

feat: enable GovDAO to modify account restriction status

Open piux2 opened this issue 6 months ago • 2 comments

Requirement

https://github.com/gnolang/gno/issues/4143

Description

  • The setting system parameters API is designed to set the full list of parameters as a slice. To update the unrestricted accounts list, we implemented separate add and remove proposal requests to update the status of individual accounts instead of setting the entire list every time an update is needed.
  • Added logic to update the status of accounts in auth keeper auth.WillSetParams() upon parameter changes.
  • Added GetSystemParams method in sys/params
  • Added full-cycle integration tests to update the unrestricted account status from GovDAO.

piux2 avatar Jun 09 '25 22:06 piux2

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • [ ] IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: piux2/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Gno2D2 avatar Jun 09 '25 22:06 Gno2D2