gno icon indicating copy to clipboard operation
gno copied to clipboard

fix(gnovm): alternative solution switch var capture

Open ltzmaxwell opened this issue 6 months ago • 3 comments

alternative solution to #4347

ltzmaxwell avatar Jun 09 '25 16:06 ltzmaxwell

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • [ ] IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Gno2D2 avatar Jun 09 '25 16:06 Gno2D2

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/transcribe.go 16.66% 4 Missing and 1 partial :warning:
gnovm/pkg/gnolang/preprocess.go 92.59% 1 Missing and 1 partial :warning:
gnovm/pkg/gnolang/nodes.go 0.00% 1 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Jun 09 '25 16:06 codecov[bot]

Just cross-referencing: I think the other PR is a better approach.

thehowl avatar Jun 24 '25 18:06 thehowl

closing in favor of #4347

jaekwon avatar Jul 03 '25 03:07 jaekwon