gno icon indicating copy to clipboard operation
gno copied to clipboard

feat(examples): r/place

Open NicolasMelet opened this issue 7 months ago • 12 comments

The r/place realm mimics the famous r/place from reddit.

The concept is simple, we have a big canvas on which multiple pixels are presents, and everyone can color one pixel with the color of their choice every 2 minutes. This allows multiple users to gather and create little pieces of art together ! We also have an admin system that allow to ban/unban certain users, or promote new users to be admin too

NicolasMelet avatar May 06 '25 13:05 NicolasMelet

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • [ ] IGNORE the bot requirements for this PR (force green CI check)
  • [ ] The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info) 🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: louonezime/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least one of these user(s) reviewed the pull request: [jefft0 leohhhn n0izn0iz notJoon omarsy x1unix] (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🟢 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

Gno2D2 avatar May 06 '25 13:05 Gno2D2

Please add a description to your PR!

leohhhn avatar May 13 '25 09:05 leohhhn

Hello @NicolasMelet . The CI check failed for mod-tidy. Can you try running go mod tidy?

jefft0 avatar May 13 '25 14:05 jefft0

Hello @NicolasMelet . The CI check failed for mod-tidy. Can you try running go mod tidy?

I'm a bit confused, this is the second pr in which the CI has problems with mod-tidy, but doing go mod tidy or make tidy doesn't appear to do anything or change any file

NicolasMelet avatar May 15 '25 10:05 NicolasMelet

Hello @NicolasMelet . The CI check failed for mod-tidy. Can you try running go mod tidy?

I'm a bit confused, this is the second pr in which the CI has problems with mod-tidy, but doing go mod tidy or make tidy doesn't appear to do anything or change any file

Now the CI check seems happy. :grin:

jefft0 avatar May 15 '25 10:05 jefft0

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar May 15 '25 17:05 codecov[bot]

I tried your branch, gno mod tidy does indeed change the file (adds a newline). Run it directly in the r/eva/place folder.

@jefft0 since this PR is a first-time contribution, tech-staff/devrels have to maunally approve a CI run which is why it seemed green to you (not all checks ran)

leohhhn avatar May 15 '25 17:05 leohhhn

@NicolasMelet - have you had the chance to work on some tests for the app?

leohhhn avatar Jun 16 '25 12:06 leohhhn

@NicolasMelet - have you had the chance to work on some tests for the app?

Not yet, I was handling some issues with my computer and fixing the cross issue on Submit (by the way it now works with the command lines by removing the empty arg for "cross", but Adena still sees one too many argument) Now that this is fixed, I will handle the rest of your comments and make tests !

NicolasMelet avatar Jun 16 '25 13:06 NicolasMelet

I have created more tests, this should be good now ! https://github.com/gnolang/gno/pull/4254/commits/674fbade6dab5343f0a0682bbfcdaa7a2d5f0c62

NicolasMelet avatar Jun 18 '25 12:06 NicolasMelet

As said in the following hackerspace post, I will try to implement a new markdown extension to make it possible to click directly on our svg squares. If this works we will have to adapt the place realm a bit https://github.com/gnolang/hackerspace/issues/116#issuecomment-3026895497

NicolasMelet avatar Jul 02 '25 08:07 NicolasMelet

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

github-actions[bot] avatar Oct 28 '25 02:10 github-actions[bot]