gno icon indicating copy to clipboard operation
gno copied to clipboard

feat(example): friendly organizer

Open Chaegnal opened this issue 8 months ago • 6 comments

This realms is directed toward friend group that want to organize meet-up more easily. Each group has admins who can create DAO poll in order to execute certain action while ensuring the agreement of the majority. (r/chaegnal/organizer)

Uses the pure package 'p/nt/commondao' for the DAO implementation.

Each file is tested and comments were added to enhance readability.

Chaegnal avatar Apr 18 '25 14:04 Chaegnal

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • [ ] IGNORE the bot requirements for this PR (force green CI check)
  • [ ] The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info) 🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: Chaegnal/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least one of these user(s) reviewed the pull request: [jefft0 leohhhn n0izn0iz notJoon omarsy x1unix] (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🟢 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

Gno2D2 avatar Apr 18 '25 14:04 Gno2D2

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar May 06 '25 08:05 codecov[bot]

Leaving some comments on the DAO package - please, try to split up the file into smaller pieces based on some topic or similar, to make it easier to understand and read the code. This applies for all code you wrote :)

I'll take another look when you fix the current comments

In this commit: d5ca4e8

I split up the code into smaller, more comprehensive files. I could also, in the r/chaegnal/organizer, split the types in one separate file, let me know !

I will also redo the test in a future commit !

EDIT: The test have been fixed and put into file to respect the new file structure -> ac32354

Chaegnal avatar May 13 '25 16:05 Chaegnal

Hi @Chaegnal . The CI check for mod-tidy says "Some gno.mod files are not tidy, please run 'make tidy'." Are you able to do this?

jefft0 avatar May 21 '25 15:05 jefft0

Hi @Chaegnal . The CI check for mod-tidy says "Some gno.mod files are not tidy, please run 'make tidy'." Are you able to do this?

Hi @jefft0, I ran the make tidy ! The result of that can be found in this commit: 95a904f

Chaegnal avatar May 21 '25 16:05 Chaegnal

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

github-actions[bot] avatar Nov 11 '25 02:11 github-actions[bot]