gno icon indicating copy to clipboard operation
gno copied to clipboard

feat: add r/sys/params + params genesis support

Open moul opened this issue 1 year ago • 1 comments

  • [ ] add r/sys/params (dummy version?)
  • [ ] add genesis/params.txt
  • [ ] port some existing configurations

Depends on #2920

moul avatar Oct 22 '24 23:10 moul

Codecov Report

Attention: Patch coverage is 79.45205% with 30 lines in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (60304df) to head (1ce1a27). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gno.land/pkg/gnoland/genesis.go 59.45% 10 Missing and 5 partials :warning:
gno.land/pkg/gnoland/param.go 80.76% 12 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
+ Coverage   63.76%   63.78%   +0.01%     
==========================================
  Files         548      549       +1     
  Lines       78681    78819     +138     
==========================================
+ Hits        50171    50273     +102     
- Misses      25128    25154      +26     
- Partials     3382     3392      +10     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 73.70% <77.94%> (+0.07%) :arrow_up:
gnovm 67.93% <100.00%> (+<0.01%) :arrow_up:
misc/genstd 79.72% <ø> (ø)
tm2 62.41% <100.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 22 '24 23:10 codecov[bot]

I believe that Codecov has false negatives. It flags lines that are actually tested at least twice.

moul avatar Oct 26 '24 02:10 moul

Ready for review. The CI is red, but the new code is tested. The conflict is easy to fix, I'll fix it soon. Blocking #2911.

moul avatar Oct 30 '24 22:10 moul