gno icon indicating copy to clipboard operation
gno copied to clipboard

fix(gnovm): save object when refCount changed

Open omarsy opened this issue 1 year ago • 1 comments

closes: #2266 #1543

Contributors' checklist...
  • [ ] Added new tests, or not needed, or not feasible
  • [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [ ] Updated the official documentation or not needed
  • [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [ ] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests

omarsy avatar Oct 21 '24 15:10 omarsy

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Oct 21 '24 15:10 codecov[bot]

Hello @omarsy . There is a merge conflict with master in gno.land/pkg/sdk/vm/gas_test.go . Can you resolve it?

jefft0 avatar Nov 19 '24 16:11 jefft0

Removed the review/triage-pending label because jefft0 approved. Ready for core devs to review if the change is technically correct.

jefft0 avatar Nov 20 '24 08:11 jefft0

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):
  • [x] IGNORE the bot requirements for this PR (force green CI check) (checked by @zivkovicmilos)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: TERITORI/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Gno2D2 avatar Nov 28 '24 18:11 Gno2D2

@omarsy Can you please check the CI? 🙏

zivkovicmilos avatar Dec 04 '24 09:12 zivkovicmilos

@omarsy Can you please check the CI? 🙏

Done ^^

omarsy avatar Dec 04 '24 10:12 omarsy

@omarsy

Can you please check the CI? 🙏

zivkovicmilos avatar Jan 06 '25 11:01 zivkovicmilos

@omarsy

Can you please check the CI? 🙏

Done ! ^^

omarsy avatar Jan 06 '25 20:01 omarsy

can you update the branch? and then we can merge

thehowl avatar Jan 14 '25 14:01 thehowl

can you update the branch? and then we can merge

done ^^

omarsy avatar Jan 14 '25 23:01 omarsy