fix(gnovm): save object when refCount changed
closes: #2266 #1543
Contributors' checklist...
- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a
BREAKING CHANGE: xxxmessage was included in the description - [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:loudspeaker: Thoughts on this report? Let us know!
Hello @omarsy . There is a merge conflict with master in gno.land/pkg/sdk/vm/gas_test.go . Can you resolve it?
Removed the review/triage-pending label because jefft0 approved. Ready for core devs to review if the change is technically correct.
🛠 PR Checks Summary
🔴 Maintainers must be able to edit this pull request (more info)
Manual Checks (for Reviewers):
- [x] IGNORE the bot requirements for this PR (force green CI check) (checked by @zivkovicmilos)
Read More
🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.
✅ Automated Checks (for Contributors):
🔴 Maintainers must be able to edit this pull request (more info)
☑️ Contributor Actions:
- Fix any issues flagged by automated checks.
- Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include
BREAKING CHANGEnotes. - Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
- Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met └── 🟢 The pull request was created from a fork (head branch repo: TERITORI/gno)Then
🔴 Requirement not satisfied └── 🔴 Maintainer can modify this pull requestManual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met └── 🟢 On every pull requestCan be checked by
- Any user with comment edit permission
@omarsy Can you please check the CI? 🙏
@omarsy Can you please check the CI? 🙏
Done ^^
@omarsy
Can you please check the CI? 🙏
@omarsy
Can you please check the CI? 🙏
Done ! ^^
can you update the branch? and then we can merge
can you update the branch? and then we can merge
done ^^