feat(genesis): deployerAddress passed as parameter

[Villaquiranm]

Contributors' checklist...

• [ ] Added new tests, or not needed, or not feasible
• [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• [ ] Updated the official documentation or not needed
• [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• [ ] Added references to related issues and PRs
• [ ] Provided any useful hints for running manual tests

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

[Villaquiranm]

closes #2573

[thehowl]

No longer blocked; please merge master to fix the go.mod CI and fix lint CI. I'll wait for the review team to do a first pass.

[jefft0]

Hello @Villaquiranm . This PR closes issue https://github.com/gnolang/gno/issues/2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

[Villaquiranm]

Hey @jefft0 thanks for your review. I mean I could put g1sh0uldn0thappen but that being a non valid address, maybe it is better to fail if the parameter is not given ? that's why I left it as it was but sure I could put 'g1sh0uldn0thappen'

Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

[jefft0]

Hey @jefft0 thanks for your review. I mean I could put g1sh0uldn0thappen but that being a non valid address, maybe it is better to fail if the parameter is not given ? that's why I left it as it was but sure I could put 'g1sh0uldn0thappen'

Hello @Villaquiranm . This PR closes issue #2573 . I see that it adds a way to configure the deployer address from the command line. But the issue also says "". But the issue also says to change to a default "deployer address like g1sh0uldn0thappen..." Is this still needed?

Hi @Villaquiranm . I can't tell you the answer. My job as part of "review/triage" is to anticipate the questions that the core devs would ask during their final review, and to make sure they have been considered.

The mnemonic (and private key) of address g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5 is well-known, and thehowl suggests that it shouldn't be the default (like it is in your PR). What do you think are the options to deal with this?

[jefft0]

Removed the review/triage-pending label because zivkovicmilos changed this PR to draft status.

[Gno2D2]

Merge Requirements

The following requirements must be fulfilled before a pull request can be merged. Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🔴 Maintainers must be able to edit this pull request 🔴 The pull request head branch must be up-to-date with its base

Details

Maintainers must be able to edit this pull request

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (TERITORI:feat/configure-address-deployer-genesis) is up to date with base (master): behind by 21 / ahead by 18

Manual Checks

• [ ] The pull request description provides enough details

Details

The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

• team core-contributors