gno icon indicating copy to clipboard operation
gno copied to clipboard

feat(examples): grc20 refactor

Open moul opened this issue 1 year ago • 3 comments

This PR extracts the grc20 refactor from #2551, which is a meta PR containing several contract improvements and additions that depend on new Gnovm features that haven't been merged yet.

Please review this grc20 refactor with a focus on its API. Several valuable comments can be found in #2551. Additionally, you can discover new contracts using grc20 in #2551, such as minidex, atomicswap, grc20reg, test20, and vault.

Addresses #1832

moul avatar Oct 19 '24 01:10 moul

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.76%. Comparing base (60304df) to head (b40f6fb). Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2983   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files         548      548           
  Lines       78681    78681           
=======================================
+ Hits        50171    50172    +1     
- Misses      25128    25129    +1     
+ Partials     3382     3380    -2     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 73.62% <ø> (ø)
gnovm 67.92% <ø> (ø)
tm2 62.41% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 19 '24 01:10 codecov[bot]

cc @MikaelVallenet @n0izn0iz, any thoughts?

leohhhn avatar Oct 19 '24 01:10 leohhhn

cc @MikaelVallenet @n0izn0iz, any thoughts?

looks good to me, i like the teller pattern & add metadata in token level instead of ledger/bank i'm just thinking if it should take another pkg as an extension of primitive grc20 pkg

MikaelVallenet avatar Oct 20 '24 17:10 MikaelVallenet

Merged #3046 over this one to make the CI green.

Depends on #3046.

moul avatar Oct 29 '24 22:10 moul

@leohhhn do you want to update the doc in this PR or in your big refactor?

moul avatar Oct 31 '24 19:10 moul