gno icon indicating copy to clipboard operation
gno copied to clipboard

feat: clean up `p2p` & implement bootnode (`seed` peers) support

Open zivkovicmilos opened this issue 1 year ago • 1 comments

Description

This PR introduces bootnode (seed mode) support for TM2 peering, and cleans up parts of the p2p module codebase.

Closes #2308

Contributors' checklist...
  • [x] Added new tests, or not needed, or not feasible
  • [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [x] Updated the official documentation or not needed
  • [x] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [x] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests
  • [ ] Added new benchmarks to generated graphs, if any. More info here.

zivkovicmilos avatar Sep 26 '24 10:09 zivkovicmilos

There is a leftover issue with this PR that I'm currently investigating, which is a hanging test somewhere in TM2.

I will resolve this before opening the PR for reviews 🙏

zivkovicmilos avatar Nov 17 '24 11:11 zivkovicmilos

Opening this up for an initial review 🙏

I have no idea why the gno.land testing suite hangs on the PR -- it runs fine locally 🤷‍♂️

zivkovicmilos avatar Nov 19 '24 16:11 zivkovicmilos

@sw360cab @albttx @r3v4s

Ready for you to take this for a spin 🙏

zivkovicmilos avatar Nov 19 '24 17:11 zivkovicmilos

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • [ ] IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Gno2D2 avatar Nov 29 '24 02:11 Gno2D2