gno icon indicating copy to clipboard operation
gno copied to clipboard
verified publisher icon gnolang

feat(examples): Define Ownable and Transferrable Interfaces

Open linhpn99 opened this issue 1 year ago • 7 comments

Contributors' checklist...
  • [ ] Added new tests, or not needed, or not feasible
  • [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [ ] Updated the official documentation or not needed
  • [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [ ] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests
  • [ ] Added new benchmarks to generated graphs, if any. More info here.

linhpn99 avatar May 26 '24 09:05 linhpn99

@moul Temporarily, I am still defining individual error codes for each package. We need to review and consolidate them into a common error code set for all packages

linhpn99 avatar May 26 '24 13:05 linhpn99

@moul LGTY ?

linhpn99 avatar May 27 '24 16:05 linhpn99

@moul i'm ready for the second review

linhpn99 avatar Jun 11 '24 19:06 linhpn99

@linhpn99, in this new round of reviews, I found the same issues I had previously mentioned. The helper is not functioning as the title suggests, and it should not exist as the previous implementation was better. Additionally, a concerning change that conceals a genuine bug has been maintained.

I have two requests for you:

  • Please do not mark the review as "resolved" on your own; fix the problems, then allow the reviewers to verify your fix and resolve the discussion.
  • Exercise extra caution. You are frequently pinging us for reviews and quickly patching things, but the quality is not up to par. We do not have the time to review your work multiple times.

moul avatar Jun 11 '24 20:06 moul

@linhpn99, in this new round of reviews, I found the same issues I had previously mentioned. The helper is not functioning as the title suggests, and it should not exist as the previous implementation was better. Additionally, a concerning change that conceals a genuine bug has been maintained.

I have two requests for you:

  • Please do not mark the review as "resolved" on your own; fix the problems, then allow the reviewers to verify your fix and resolve the discussion.
  • Exercise extra caution. You are frequently pinging us for reviews and quickly patching things, but the quality is not up to par. We do not have the time to review your work multiple times.
  • You are frequently pinging us for reviews and quickly patching things, but the quality is not up to par. We do not have the time to review your work multiple times

Hey, please don't misunderstand. You pointed this out to me once, and I have always remembered it. I still have kept the conversations open and have not marked them as resolved

It seems I was a bit hasty in pushing quick fixes. Due to the time zone difference, I wanted to take advantage of the time you were still working to get timely support. Next time, I will pay more attention to the quality of the code before requesting a review

Sorry for any inconvenience caused !

linhpn99 avatar Jun 12 '24 01:06 linhpn99

See comments.

All related fixes : https://github.com/gnolang/gno/pull/2198/commits/8bd3ac0bd411c9f2adee3bbc466e57ed6f33ac5b & https://github.com/gnolang/gno/pull/2198/commits/0e7f9d5cc8c4298b704941727e7232c4bf6a17dd

linhpn99 avatar Jun 12 '24 01:06 linhpn99

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Jul 14 '24 23:07 codecov[bot]

@moul I see you converted it to draft. Do you intend to change something in the master branch?

linhpn99 avatar Jul 20 '24 03:07 linhpn99

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

github-actions[bot] avatar Dec 21 '24 01:12 github-actions[bot]

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

github-actions[bot] avatar Aug 14 '25 02:08 github-actions[bot]

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

github-actions[bot] avatar Nov 14 '25 02:11 github-actions[bot]

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • [ ] IGNORE the bot requirements for this PR (force green CI check)
  • [ ] The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info) 🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: linhpn99/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least one of these user(s) reviewed the pull request: [jefft0 leohhhn n0izn0iz notJoon omarsy x1unix] (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🟢 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

Gno2D2 avatar Nov 18 '25 11:11 Gno2D2