gno icon indicating copy to clipboard operation
gno copied to clipboard

chore(gnovm): deprecate & remove std.CurrentRealmPath()

Open linhpn99 opened this issue 9 months ago • 3 comments

Contributors' checklist...
  • [ ] Added new tests, or not needed, or not feasible
  • [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [ ] Updated the official documentation or not needed
  • [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [x] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests
  • [ ] Added new benchmarks to generated graphs, if any. More info here.

linhpn99 avatar May 13 '24 15:05 linhpn99

this PR relates to https://github.com/gnolang/gno/issues/2045

linhpn99 avatar May 13 '24 15:05 linhpn99

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.02%. Comparing base (e1586a5) to head (5e7f411).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2087   +/-   ##
=======================================
  Coverage   49.01%   49.02%           
=======================================
  Files         576      576           
  Lines       77604    77578   -26     
=======================================
- Hits        38035    38029    -6     
+ Misses      36486    36467   -19     
+ Partials     3083     3082    -1     
Flag Coverage Δ
gnovm 41.93% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 13 '24 15:05 codecov[bot]

@thehowl hope u give a review

linhpn99 avatar May 13 '24 17:05 linhpn99

@thehowl does my PR good enough to approve ?

linhpn99 avatar May 16 '24 06:05 linhpn99

LGTM, @gfanton for second review

thehowl avatar May 23 '24 07:05 thehowl