fix: global var dependencies

[petar-dambovaliev]

fixes this by adding missing logic in in findUndefined2

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 55.17241% with 65 lines in your changes missing coverage. Please review.

Project coverage is 60.83%. Comparing base (aa4bc99) to head (05f348a).

Files with missing lines	Patch %	Lines
gnovm/pkg/gnolang/preprocess.go	55.17%	57 Missing and 8 partials :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
- Coverage   60.83%   60.83%   -0.01%     
==========================================
  Files         563      563              
  Lines       75169    75314     +145     
==========================================
+ Hits        45730    45818      +88     
- Misses      26072    26125      +53     
- Partials     3367     3371       +4     

Flag	Coverage Δ
contribs/gnodev	61.46% <ø> (+0.81%)	:arrow_up:
contribs/gnofaucet	15.31% <ø> (+0.85%)	:arrow_up:
gno.land	67.21% <ø> (ø)
gnovm	65.54% <55.17%> (-0.05%)	:arrow_down:
misc/genstd	80.54% <ø> (ø)
misc/logos	19.88% <ø> (-0.36%)	:arrow_down:
tm2	62.09% <ø> (+0.02%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[jaekwon]

looking at this

[jaekwon]

#2418 is now working, instead of passing in 'st' symbol table, this PR should should incorporate #2418, unless #2418 solves this problem already.

[petar-dambovaliev]

This is the first part of my review. I want to make sure I understand the intentions before completing it.

Tell me if I have the main idea of what this is solving. Previously, names referenced by globally defined function literals were not being verified to have been defined. These changes use this unique case as an entrypoint to recursively analyze all of the function literal's statements to ensure that all names referenced are actually defined.

Otherwise, please see the couple of comments I've left.

Yes, that is correct.