gno icon indicating copy to clipboard operation
gno copied to clipboard

chore(ci): setup docker build cache

Open albttx opened this issue 9 months ago • 2 comments

Testing https://docs.docker.com/build/ci/github-actions/cache/#github-cache

Comparing to !6719 build reduce from ~15 minutes to 9 minutes

image

image

albttx avatar May 09 '24 07:05 albttx

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.64%. Comparing base (bedd0f9) to head (59ae685). Report is 197 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2062      +/-   ##
==========================================
- Coverage   54.65%   54.64%   -0.02%     
==========================================
  Files         583      583              
  Lines       78508    78508              
==========================================
- Hits        42909    42901       -8     
- Misses      32385    32393       +8     
  Partials     3214     3214              
Flag Coverage Δ
contribs/gnodev 23.81% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (+0.85%) :arrow_up:
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gno.land 62.13% <ø> (ø)
gnovm 59.95% <ø> (ø)
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 73.90% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (ø)
misc/loop 0.00% <ø> (ø)
tm2 54.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 07:05 codecov[bot]

After mutliple tries, i'm not sure it's improve a lot the build time.

probably because it's concurrent build.

albttx avatar May 09 '24 09:05 albttx

@albttx can you please update the branch to the latest master and resolve conflicts? 🙏

zivkovicmilos avatar Jun 12 '24 16:06 zivkovicmilos

@zivkovicmilos So i fixed / rebased this PR, and added a workflow that didn't push the Docker image (this can be remove if you want).

The idea is to add a simple dockerfile that could be use by dev (because the goreleaser version require the go toolchain locally, this is a more "pure" docker image where the binaries are built inside the images.

This Dockerfile is require for me for the ci/portal-loop test!

albttx avatar Jun 13 '24 09:06 albttx

@zivkovicmilos is this still relevant?

ajnavarro avatar Jul 22 '24 13:07 ajnavarro

@zivkovicmilos is this still relevant?

@sw360cab @zivkovicmilos the question still stands :)

Kouteki avatar Oct 08 '24 10:10 Kouteki

@Kouteki I am working on a template of optimized image in the dedicated gno infra repository

sw360cab avatar Oct 08 '24 10:10 sw360cab

This PR can be close

albttx avatar Oct 08 '24 13:10 albttx