gno icon indicating copy to clipboard operation
gno copied to clipboard

feat!: remove flag `-transpile` from `gno test`

Open harry-hov opened this issue 1 year ago • 2 comments

The -transpile flag in the gno test command duplicates the functionality of the standalone gno transpile command. Removed the unnecessary -transpile flag from the gno test command.

gno test should only be focused on testing!

harry-hov avatar May 07 '24 14:05 harry-hov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.98%. Comparing base (0d299c3) to head (ab90f24).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
+ Coverage   49.96%   49.98%   +0.02%     
==========================================
  Files         578      578              
  Lines       77864    77808      -56     
==========================================
- Hits        38903    38896       -7     
+ Misses      35839    35790      -49     
  Partials     3122     3122              
Flag Coverage Δ
gnovm 45.16% <ø> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 14:05 codecov[bot]

cc @moul wdyt?

it seems that transpiling mostly served the purpose of attempting to build the transpiled go source; ie. static checking. though, effectively, this is moved to gno lint in https://github.com/gnolang/gno/pull/1730 . I tend to agree with @harry-hov to separate the concerns

thehowl avatar May 07 '24 21:05 thehowl

My goal with this flag was to have « gno test » exiting 0 of everything is OK and 1 of anything is bad.

‘before this flag, we basically had to run two commands to « test ».

ideally we should remove the flag but have a stronger type checking.

as soon as we’re testing to transpire on the CI, I’m fine removing the flag.

moul avatar May 29 '24 11:05 moul

ideally we should remove the flag but have a stronger type checking.

I agree. I think @thehowl is already working on this!

as soon as we’re testing to transpire on the CI, I’m fine removing the flag.

We already have workflow for transpiling /examples https://github.com/gnolang/gno/blob/5a64b2586148491777ae124aa984228df3d82e70/.github/workflows/examples.yml#L33

Infact we never run gno test with -transpile flag on CI.

harry-hov avatar May 29 '24 11:05 harry-hov

Let's remove the flag. Let's keep transpile in the CI and wait for stronger type checking to make gno test testing everything, as it should.

moul avatar May 29 '24 13:05 moul

We'll add type checking in gno test with #1730

thehowl avatar May 30 '24 17:05 thehowl