gno icon indicating copy to clipboard operation
gno copied to clipboard

fix(#1966): go2Gno loses type info

Open omarsy opened this issue 1 year ago • 4 comments

fixes #1966

Contributors' checklist...
  • [ ] Added new tests, or not needed, or not feasible
  • [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [ ] Updated the official documentation or not needed
  • [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [ ] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests
  • [ ] Added new benchmarks to generated graphs, if any. More info here.

omarsy avatar May 01 '24 21:05 omarsy

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.85%. Comparing base (ccc6d5b) to head (3c7b5ed).

Files Patch % Lines
gnovm/pkg/gnolang/preprocess.go 85.71% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
- Coverage   49.04%   48.85%   -0.20%     
==========================================
  Files         576      579       +3     
  Lines       77556    78038     +482     
==========================================
+ Hits        38035    38122      +87     
- Misses      36439    36830     +391     
- Partials     3082     3086       +4     
Flag Coverage Δ
gnovm 42.14% <85.71%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 01 '24 22:05 codecov[bot]

cc @ltzmaxwell

thehowl avatar May 07 '24 18:05 thehowl

thank you for your work, start looking.

ltzmaxwell avatar May 08 '24 11:05 ltzmaxwell

cc @deelawn for a second look.

ltzmaxwell avatar May 13 '24 11:05 ltzmaxwell