gno icon indicating copy to clipboard operation
gno copied to clipboard

chore: convert AddressList into a HashSet

Open albttx opened this issue 2 years ago • 3 comments

Hello, first contribution from me :wave:

Let me know what you think ?

I've noticed there is also the coins.gno that could benefit of using a HashSet, I can do the PR if you want

albttx avatar May 17 '22 13:05 albttx

Just see the pipeline failed with :

panic: got unexpected error: interface conversion: gno.Type is *gno.DeclaredType, not *gno.MapType [recovered]
	panic: got unexpected error: interface conversion: gno.Type is *gno.DeclaredType, not *gno.MapType

I guess the Map cause non-deterministic issues,

just discovered your avl implementation, I'll try to implement

albttx avatar May 17 '22 13:05 albttx

Using avl get me this error

$ make test test.files1
panic: got unexpected error: std/addr_set.gno:1: unexpected type declaration type *gno.StarExpr [recovered]
        panic: got unexpected error: std/addr_set.gno:1: unexpected type declaration type *gno.StarExpr

albttx avatar May 17 '22 13:05 albttx

@moul i've fixed everything,

i had to add the avl package in stdlbs, what do you think of this ?

make test.go1 is a success

albttx avatar Jul 23 '22 11:07 albttx