fix: correct comparison between different types
don't merge.
this PR is divided from #1426. the dependence relationship is: #1426 <- this one..
Codecov Report
Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
Project coverage is 59.97%. Comparing base (
1180def) to head (e2eba49). Report is 39 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| gnovm/pkg/gnolang/preprocess.go | 87.50% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1890 +/- ##
==========================================
+ Coverage 55.01% 59.97% +4.96%
==========================================
Files 595 560 -35
Lines 79727 77547 -2180
==========================================
+ Hits 43858 46507 +2649
+ Misses 32550 27516 -5034
- Partials 3319 3524 +205
| Flag | Coverage Δ | |
|---|---|---|
| contribs/gnodev | 61.40% <ø> (+35.40%) |
:arrow_up: |
| contribs/gnofaucet | 15.31% <ø> (ø) |
|
| gno.land | 64.18% <ø> (-0.06%) |
:arrow_down: |
| gnovm | 64.15% <100.00%> (+3.90%) |
:arrow_up: |
| misc/genstd | 80.54% <ø> (ø) |
|
| misc/logos | 20.23% <ø> (+2.85%) |
:arrow_up: |
| tm2 | 61.99% <ø> (+7.54%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ltzmaxwell can you merge master and fixup this PR for review? :)
@ltzmaxwell can you merge master and fixup this PR for review? :)
yes sure, in progress. @thehowl .
Hi @thehowl , this one is good for review. 🙏