gno icon indicating copy to clipboard operation
gno copied to clipboard

fix: correct type for shift expression

Open ltzmaxwell opened this issue 1 year ago • 3 comments

  1. This is a fix to gnolang/gno/issues/1462;
  2. NOTE: This PR should be reviewed following the potential merger of #1426, from which it is both decoupled and dependent. #1426 serves as base branch of this one.
  3. NOTE: Currently, this PR displays all code including that from #1426, because it is being compared to the master branch instead of differing against #1426 directly.

ltzmaxwell avatar Mar 14 '24 16:03 ltzmaxwell

This is not reviewable. There is too many dependencies on other issues and prs.

petar-dambovaliev avatar Mar 23 '24 04:03 petar-dambovaliev

This is not reviewable. There is too many dependencies on other issues and prs.

that it is. hopefully I will make #1426 available next week.

ltzmaxwell avatar Mar 23 '24 04:03 ltzmaxwell

Codecov Report

Attention: Patch coverage is 95.28796% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.10%. Comparing base (912a5db) to head (19a2cf8). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/type_check.go 92.85% 4 Missing :warning:
gnovm/pkg/gnolang/values.go 87.50% 3 Missing :warning:
gnovm/pkg/gnolang/preprocess.go 98.11% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
+ Coverage   60.97%   61.10%   +0.12%     
==========================================
  Files         564      564              
  Lines       75273    75359      +86     
==========================================
+ Hits        45897    46045     +148     
+ Misses      26008    25949      -59     
+ Partials     3368     3365       -3     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.92% <ø> (ø)
gnovm 66.17% <95.28%> (+0.39%) :arrow_up:
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 61.96% <ø> (-0.16%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 01 '24 08:07 codecov[bot]

Hi @thehowl , this one is good to review too.

ltzmaxwell avatar Aug 06 '24 01:08 ltzmaxwell

I see that some tests are not passing, even if they print the correct results. This is due to eval_tests not trimming spaces in results. Let me fix this.

mvertes avatar Oct 15 '24 07:10 mvertes

thanks for the speedy merge @mvertes! <3

thehowl avatar Oct 15 '24 17:10 thehowl