gno icon indicating copy to clipboard operation
gno copied to clipboard

feat(vm): add `CommentGroup` and `Comment` attributes

Open gfanton opened this issue 1 year ago • 2 comments

Add CommentGroup and Comment attribute support to the VM. The main reason behind this is to have the ability to handle special directives such as // nolint without having to re-parse every file. I've left some XXX comments in places where I'm unsure of what to do.

partially address: https://github.com/gnolang/gno/issues/1042 related to: https://github.com/gnolang/gno/pull/1450

Contributors' checklist...
  • [ ] Added new tests, or not needed, or not feasible
  • [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • [ ] Updated the official documentation or not needed
  • [ ] No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • [ ] Added references to related issues and PRs
  • [ ] Provided any useful hints for running manual tests
  • [ ] Added new benchmarks to generated graphs, if any. More info here.

gfanton avatar Feb 15 '24 09:02 gfanton

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (0cce745) 56.17% compared to head (58280a9) 56.23%. Report is 1 commits behind head on master.

Files Patch % Lines
gnovm/pkg/gnolang/nodes.go 0.00% 54 Missing :warning:
gnovm/pkg/gnolang/nodes_copy.go 0.00% 10 Missing :warning:
gnovm/pkg/gnolang/nodes_string.go 0.00% 4 Missing :warning:
gnovm/pkg/gnolang/go2gno.go 94.91% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
+ Coverage   56.17%   56.23%   +0.05%     
==========================================
  Files         439      439              
  Lines       66242    66723     +481     
==========================================
+ Hits        37209    37519     +310     
- Misses      26143    26299     +156     
- Partials     2890     2905      +15     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 15 '24 09:02 codecov[bot]

When this is merged I could help setting up the base for the linter

0xtekgrinder avatar Feb 15 '24 17:02 0xtekgrinder